[BACKEND] Migrate to SQLite; Migrate to OpenAPI; Migrate to .env file; - #38
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e16361610
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val serverCertificatePath = readRequired(dotenv, "SERVER_CERTIFICATE_PATH").run | ||
| val serverPrivateKeyPath = readRequired(dotenv, "SERVER_PRIVATE_KEY_PATH").run |
There was a problem hiding this comment.
Do not require TLS paths when the HTTP protocol is selected
When PROTOCOL=http is used without certificate settings—as the .env.example comment explicitly permits—the loader fails with Missing required .env value before Main.createServerConfig can select the HTTP branch. This makes a normal HTTP deployment fail unless it supplies unused, potentially nonexistent TLS paths; only load these values when HTTPS is selected (or make them optional).
Useful? React with 👍 / 👎.
No description provided.