Skip to content

[BACKEND] Migrate to SQLite; Migrate to OpenAPI; Migrate to .env file; - #38

Merged
aivanovski merged 6 commits into
mainfrom
feature/migrate-to-sqlite
Jul 24, 2026
Merged

[BACKEND] Migrate to SQLite; Migrate to OpenAPI; Migrate to .env file;#38
aivanovski merged 6 commits into
mainfrom
feature/migrate-to-sqlite

Conversation

@aivanovski

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e16361610

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +18 to +19
val serverCertificatePath = readRequired(dotenv, "SERVER_CERTIFICATE_PATH").run
val serverPrivateKeyPath = readRequired(dotenv, "SERVER_PRIVATE_KEY_PATH").run

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not require TLS paths when the HTTP protocol is selected

When PROTOCOL=http is used without certificate settings—as the .env.example comment explicitly permits—the loader fails with Missing required .env value before Main.createServerConfig can select the HTTP branch. This makes a normal HTTP deployment fail unless it supplies unused, potentially nonexistent TLS paths; only load these values when HTTPS is selected (or make them optional).

Useful? React with 👍 / 👎.

@aivanovski
aivanovski merged commit 3a2e59e into main Jul 24, 2026
5 checks passed
@aivanovski
aivanovski deleted the feature/migrate-to-sqlite branch July 24, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant