This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Open
Conversation
* Fix LoadError of `json-schema`
* In order to update api of minimum required.
|
This seems reasonable. @aki017 are you planning on updating the gem with the latest Slack API calls? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason why I create this PR
Recently, updates aki017/slack-api-docs@1ac07b4 by
aki017/slack-api-docs-generator.But aki017/slack-ruby-gem does not follow the latest aki017/slack-api-docs. So if you execute
rake api:update, creates too many diffs in one commit.It's undesirable to revert api update if you failed.
I think that if
rake api:updatespecifies api name, only update the api, so prevent the tragedy and you can more easily update aki017/slack-ruby-gem in stagesI hope that aki017/slack-ruby-gem follows latest slack api as soon as possible.
Usage
What do I ask
What do you think this policy? Please let me oponion.