Integrated liminial_diffusion_v1 and liminal_diffusion_source models#133
Open
0xphk wants to merge 2 commits intoalembics:mainfrom
Open
Integrated liminial_diffusion_v1 and liminal_diffusion_source models#1330xphk wants to merge 2 commits intoalembics:mainfrom
0xphk wants to merge 2 commits intoalembics:mainfrom
Conversation
Collaborator
|
Thanks for the PR! It looks all good, and that it'll work. I'll see about picking the version number, etc. |
Author
|
Do you have an advice for integrating additional models? I've tested and integrated the two new KaliYuga-Ai models "lithographic" and "medieval" to a local repository. Should I create a new branch in the fork based on main (without liminal) or based on my changes in this branch? Or do I have to merge this one with main first and create a new branch from this? I'm not very familiar with branches and PR's so sorry for the beginner questions. |
Author
|
I fixed the model settings for use in colab, somehow it worked locally but not in colab, now both work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added the two liminal_diffusion models from BrainArtLabs. Their collab link was shared on reddit, so I tried to integrate them.
(https://colab.research.google.com/drive/1pHBrk8FsSmvu_TZREhZpK4jwmRBLebS_)
Models are:
liminal_diffusion_v1andliminal_diffusion_sourceI've tested both models, but only on my local instance running on a 2070 with already downloaded models.
Links and checksums are included, so download should work, but I couldn't test this here.
I really like this project and would love to contribute to it.
As this is my second PR ever, please bear with me if I've done something wrong.
best wishes