LibMCCore (scanlab, libmcenv): Fix microvector delay tick conversion and implement scatterplot channel fill #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and implement scatterplot channel fill ### feat(scanlab): convert microvector laser delays using RTC tick resolution - Added `ConvertDelaySecondsToTicks()` to convert delay seconds into RTC ticks (1 tick = 1/64 µs) and clamp to the supported range [0..32767]. - Updated `AddMicrovectorMovement()` to use the new conversion for LaserOnDelay and LaserOffDelay while preserving `-1` as the “no delay” sentinel. ### feat(libmcenv): implement scatterplot channel population from datatable - Implemented `fillScatterplotChannel()` to populate scatterplot channel/column vectors from the datatable rows with scale and offset applied. - Added basic validation and guarded channel/column creation to avoid duplicate entries. Signed-off-by: Yury Rodzikau <y.rodzikau@c1-technologies.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix microvector delay tick conversion and implement scatterplot channel fill
feat(scanlab): convert microvector laser delays using RTC tick resolution
ConvertDelaySecondsToTicks()to convert delay seconds into RTC ticks (1 tick = 1/64 µs) and clamp to the supported range [0..32767].AddMicrovectorMovement()to use the new conversion for LaserOnDelay and LaserOffDelay while preserving-1as the “no delay” sentinel.feat(libmcenv): implement scatterplot channel population from datatable
fillScatterplotChannel()to populate scatterplot channel/column vectors from the datatable rows with scale and offset applied.