Fix #8#12
Open
kurahaupo wants to merge 1 commit into
Open
Conversation
Fix logic error
Author
|
Fixed #8 |
Author
|
And... nope! Commit 247cbeb fixes
But unfortunately it breaks
I will need to investigate why, including whether the code copes with DST at the start and end of the year, rather than in the middle of the year. |
Author
|
The logic when constructing the The problem isn't specifically whether you're "currently in DST" but whether you're in the middle of the year (so the next two transitions are in different years) or around the start or end of the year (so the next two transitions are in the same year). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logic error