readOnly rows implemented. - #4
Open
0xMarK wants to merge 2 commits into
Open
Conversation
Now there can be some values that cannot be checked/unchecked. Their initial selection state will remain read-only.
Owner
|
Thanks for your pull request. I'm not sure if this is a feature that will be used quite often, so we should make this delegate method at least (at)optional. Can you point out some use case where this might be useful? Cheers, |
Author
|
I'm developing an enterprise application with a complicated user access rights. In few places the app must forbid the user from unchecking some rows while letting editing all other rows. (The user can only see that the row is checked) I've integrated this modified version to my project and it works great! Of course this feature isn't needed often. So you are absolutely right, I will make the delegate method optional. |
ALPickerViewDelegate method pickerView:readOnlyStateForRow: made optional.
Owner
|
Thank you, that looks good, will test this in one of my own apps and merge your pr in master shortly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now there can be some values that cannot be checked/unchecked. Their
initial selection state will remain read-only.