Skip to content

Improvements for 1.0#12

Open
daladim wants to merge 11 commits intoalextricity25:masterfrom
daladim:improvements_for_1.0
Open

Improvements for 1.0#12
daladim wants to merge 11 commits intoalextricity25:masterfrom
daladim:improvements_for_1.0

Conversation

@daladim
Copy link

@daladim daladim commented May 5, 2020

Hi,

Thanks for your work on this Python module.
This pull request proposes a few changes :

  • it fixes some bugs I have encountered (e.g. when handling Directives at the root of the config file)
  • it also grabs recent modifications from users rjhornsby and rubentsirunyan
  • it adds newer features (such as remove_node and add_nested_tags)
  • it uses a more object-oriented syntax (see the changes on the README) and renames a method to be more self-explicit
  • ...thus, it also breaks the API (but I think it is worth it :-) ). That is why I propose a new major version number (say, 1.0)

Thanks

@lpogo
Copy link

lpogo commented Apr 12, 2021

Hi,
code is working really nice. Parsing is much easier right now.
One point I see (not related exactly to this PR, but still), when "&" exist inside comment string, parsing failed, eg:
# Listen & NameVirtualHost resources in module
error:
File "...\venv37\lib\site-packages\pyparsing.py", line 4182, in parseImpl raise maxException pyparsing.ParseException: Expected {Group:({"</" W:(ABCD...) ">" LineEnd}) ^ Group:({"<" {{W:(ABCD...) <SP><TAB><CR><LF> W:(ABCD...) <SP><TAB><CR><LF> <= | >= | == | != | < | > | ~ <SP><TAB><CR><LF> W:(ABCD...)} | {W:(ABCD...)}...} ">" LineEnd}) ^ Group:({W:(ABCD...) Suppress:(<SP><TAB><CR><LF>) W:(0123...) LineEnd}) ^ Group:({{"#" {W:(ABCD...)}... LineEnd} ^ {"#" LineEnd}}) ^ Group:(LineEnd)}, found '&' (at char 9), (line:1, col:10)
Any ideas how to deal with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants