Open
Conversation
Contributor
|
Whoa, I totally didn't see this PR before I created #125. My PR also fixes the issue where reverse sort persists after cycling through ascending/descending order. |
|
@alfajango please merge this in |
|
This is still an issue many months later. Please merge this. |
|
Same bug here... Well, it's just a commit dude ! 2 lines to change !!!! COME ON ! |
|
seems dynatables is really dead ! |
Member
|
Not dead, just been busy. Thanks for taking the time to look at this and submit a pull request. I think I like the solution in #125 for this issue as it's a bit cleaner and doesn't modify the original value unnecessarily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When JSON contains record with null or undefined element,
Sort by string will fail with
Uncaught TypeError: Cannot read property 'toLowerCase' of nullAnd dynatable process will hang up.
This PR fix that error.
I know that we can use custom sort function. But it would be nice if dynatable handle unexpected input.
http://jsfiddle.net/georgeosddev/cR3p8/2/