Only call Array.sort() if sort columns/keys are specified#88
Open
theodorejb wants to merge 2 commits intoalfajango:masterfrom
theodorejb:only-sort-when-needed
Open
Only call Array.sort() if sort columns/keys are specified#88theodorejb wants to merge 2 commits intoalfajango:masterfrom theodorejb:only-sort-when-needed
theodorejb wants to merge 2 commits intoalfajango:masterfrom
theodorejb:only-sort-when-needed
Conversation
added 2 commits
March 14, 2014 12:24
Member
|
Thanks for the pull request. Is this code fixing a specific issue or bug? If so, could you describe what's happening so we know how to test it? |
Contributor
Author
|
Yes, this fixes issue #87. |
Member
|
I'm thinking you might be seeing intended functionality unless I'm mistaken. The default sort function if no See the originalPlacement sort function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #87