Open
Conversation
This was referenced Jul 9, 2025
5b48992 to
f06c2e9
Compare
Contributor
Author
|
Sure, my goal was precisely to split this into multiple PRs to make it easier to review; I included the last three commits because each of them is necessary to fix part of the tests on Windows. |
f06c2e9 to
5cce0db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work was done during the JNCF 2025 and is now rebased on master. I guess I won't have time to clean up everything or split it into multiple PRs before going on vacation tonight, so I'm marking it as a draft (but at least it can serve as a demo).
In short, this is achieved by providing the following headers:
src/fglm/aligned_alloc.h, which provides a handwritten implementation ofposix_memalignon Windows. I also providedposix_memalign_freefor the reason in https://learn.microsoft.com/en-us/cpp/standard-library/cstdlib?view=msvc-170#remarks-6, and modified files doingfreeover memory allocated byposix_memalignto useposix_memalign_free.src/msolve/getdelim.h, which provides Gnulib's implementation ofgetdelimandgetlineon Windows.In addition, I modified
src/neogb/sort_r.hto prevent undefined reference toqsort_r(though noporpoise/sort_r#17 might be a better idea), and addedbto fopen access modes so that we have LF instead of CRLF on Windows. I modifiedsrc/usolve/refine.cto usempz_get_ullfrom Bitwuzla instead ofmpz_get_uito always get 64-bit integers even iflongis 32-bit. I also fixed a few bugs that will be the subject of separate PRs.All tests passed on CI and my aarch64-windows machine.