Fixes a UB on shifts during root refinement#255
Draft
wegank wants to merge 1 commit intoalgebraic-solving:masterfrom
Draft
Fixes a UB on shifts during root refinement#255wegank wants to merge 1 commit intoalgebraic-solving:masterfrom
wegank wants to merge 1 commit intoalgebraic-solving:masterfrom
Conversation
wegank
force-pushed
the
shift-ub-fix-1
branch
from
6298183 to
308e43e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the affected code, when
Nlogis at least equal to 64,1L << Nlogis undefined. This PR fixes the issue by adding a default value to the expression that matches Clang's behavior on macOS.