Conversation
Spground
requested review from
Generalwin,
Pangjiping,
fengcone,
hittyt,
jwx0925,
kevinlynx and
ninan-nn
as code owners
Spground
added
component/k8s
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2358792f7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
close #180 |
jwx0925
left a comment
jwx0925
left a comment
There was a problem hiding this comment.
Update the usage instructions in the Kubernetes README to use Helm charts
Spground
force-pushed
the
feature/public-add-helm-chart
branch
from
b455672 to
d9d1b01
Compare
updated |
| **Tag 命名规则**: `k8s/<component>/<version>` | ||
| - `<component>`: 组件名称 `controller` 或 `task-executor` | ||
| - `<version>`: 版本号，例如 `v0.1.0` | ||
| - `<version>`: 镜像版本号，例如 `v0.1.0` |
There was a problem hiding this comment.
Duplacated <version> item?
| --namespace opensandbox-system \ | ||
| --create-namespace \ | ||
| --set controller.logLevel=5 \ | ||
| --set controller.batchSandboxConcurrency=64 |
There was a problem hiding this comment.
It seems no value named batchSandboxConcurrency is defined in the chart values.
| | `controller.logLevel` | Log level (0-5, higher is more verbose) | `3` | | ||
| | `controller.leaderElection.enabled` | Enable leader election | `true` | | ||
| | `controller.batchSandboxConcurrency` | Batch sandbox controller concurrency | `32` | | ||
| | `controller.poolConcurrency` | Pool controller concurrency | `1` | |
5 participants
Summary
Testing
Breaking Changes
Controller system namespace was updated from
sandbox-k8s-systemfromopensandbox-system, user maybe need to redeploy controller component in new system namespace.Checklist