chore(execd): replace logger with internal package#237
Open
Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Open
chore(execd): replace logger with internal package#237Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Conversation
Collaborator
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0866929076
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
|
/gemini review |
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
0866929 to
06c9092
Compare
06c9092 to
ba65c10
Compare
hittyt
reviewed
Feb 13, 2026
components/execd/Dockerfile
Outdated
| COPY . . | ||
| # Copy sources. | ||
| COPY components/internal ./components/internal | ||
| COPY components/execd/. ./components/execd |
Collaborator
There was a problem hiding this comment.
COPY components/execd/. here is a little bit strange, use COPY components/execd directly?
ba65c10 to
52ed8a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist