Open
Conversation
Closed
Author
Generalwin
force-pushed
the
k8s-operator
branch
2 times, most recently
from
22ce0b4 to
c5ccac3
Compare
# Conflicts: # pyproject.toml # rock/sandbox/sandbox_manager.py
Generalwin
force-pushed
the
k8s-operator
branch
from
c5ccac3 to
00401f8
Compare
FangwenDave
reviewed
Feb 12, 2026
FangwenDave
reviewed
Feb 12, 2026
FangwenDave
reviewed
Feb 12, 2026
FangwenDave
requested changes
Feb 12, 2026
FangwenDave
reviewed
Feb 12, 2026
Collaborator
FangwenDave
left a comment
FangwenDave
left a comment
There was a problem hiding this comment.
almost done, with some slight changes to be fixed
FangwenDave
approved these changes
Feb 12, 2026
StephenRi
reviewed
Feb 13, 2026
| @dataclass | ||
| class RockConfig: | ||
| ray: RayConfig = field(default_factory=RayConfig) | ||
| k8s: K8sConfig = field(default_factory=K8sConfig) |
Collaborator
There was a problem hiding this comment.
@FangwenDave 这块你后面记得做个重构。RockConfig包含OperatorConfig。OperatorConfig包含operator_type，RayConfig，K8sConfig。配置如下：
operator:
operator_type: k8s
k8s_config:
...
ray_config:
...
StephenRi
reviewed
Feb 13, 2026
| @monitor_sandbox_operation() | ||
| async def get_status(self, sandbox_id, use_rocklet: bool = False) -> SandboxStatusResponse: | ||
| if use_rocklet and self._redis_provider: | ||
| if use_rocklet and self._redis_provider and self.rock_config.runtime.operator_type != "k8s": |
StephenRi
reviewed
Feb 13, 2026
| self._namespace = namespace | ||
| self._custom_api = client.CustomObjectsApi(api_client) | ||
|
|
||
| # Rate limiting |
StephenRi
reviewed
Feb 13, 2026
| sandbox_info = await self._provider.get_status(sandbox_id) | ||
|
|
||
| # Get user info from redis if available | ||
| if self._redis_provider: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add k8s operator for sandbox deployment