Skip to content

fix: remove WINDOWS_EXPORT_ALL_SYMBOLS to prevent LNK1189 and clean up tracked-but-ignored files #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzlin237 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

fix: remove WINDOWS_EXPORT_ALL_SYMBOLS to prevent LNK1189 and clean up tracked-but-ignored files #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/05-windows-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:
Copy-Item $dll.FullName -Destination . -Force
Write-Host "Copied $dllName from $($dll.DirectoryName)"
} else {
Write-Error "$dllName not found anywhere under $buildDir"
Write-Host "WARNING: $dllName not found (all-in-one libs are static on MSVC, DLL not needed)"
}
}
}
Expand Down
15 changes: 12 additions & 3 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,18 @@ function(zvec_add_all_in_one_shared TARGET_NAME OUTPUT_NAME)
"// Auto-generated stub for ${TARGET_NAME}\n"
)

add_library(${TARGET_NAME} SHARED
${CMAKE_CURRENT_BINARY_DIR}/${TARGET_NAME}_stub.cc
)
# MSVC: build as STATIC to avoid LNK1189 (PE/COFF 65535 export limit).
# WINDOWS_EXPORT_ALL_SYMBOLS is silently ignored for static libraries.
# Consumers (fts_bench, examples) still link against this target normally.
if(MSVC)
add_library(${TARGET_NAME} STATIC
${CMAKE_CURRENT_BINARY_DIR}/${TARGET_NAME}_stub.cc
)
else()
add_library(${TARGET_NAME} SHARED
${CMAKE_CURRENT_BINARY_DIR}/${TARGET_NAME}_stub.cc
)
endif()

set_target_properties(${TARGET_NAME} PROPERTIES
OUTPUT_NAME "${OUTPUT_NAME}"
Expand Down
Loading