You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don’t think we should set ignore = dirty for all thirdparty submodules by default. In this repo, letting git status report dirty submodule worktrees is intentional: it helps us catch accidental or missed local changes under thirdparty/ before they slip through review/release work. So the current behavior is more of a safeguard/feature than a bug.
Could you share the concrete scenario where these submodules need to be fully ignored? If this is about local build artifacts or tool-generated noise in a specific submodule, we can consider a narrower fix instead of changing the repo-wide default.
Could you share the concrete scenario where these submodules need to be fully ignored? If this is about local build artifacts or tool-generated noise in a specific submodule, we can consider a narrower fix instead of changing the repo-wide default.
sparsehash and googletest can end up with local changes on Windows because of apply_patch, which keeps git status dirty. ignore = dirty is the right fit here.
I also think ignore = all is too broad for these cases, because submodule commit changes are something we still want to track.
Updated this PR to be limited to the submodules that receive patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
ignore = dirtyfor every entry in.gitmodulesso local submodule modifications do not show up as repository dirtiness.This keeps the submodule status noise down while leaving tracked changes intact.