Fixed issue with CGAL path substitution#5332
Merged
Merged
Conversation
I had ``` fastjet-config --libs | \ tr ' ' '\n' | \ grep cgal | \ sed -n 's|-L\(.*\)/cgal.*|\1|p' ``` which would do ``` /cvmfs/alice.cern.ch/el7-x86_64/Packages/cgal/4.6.3-131/lib => /cvmfs/alice.cern.ch/el7-x86_64/Packages => ``` which would then leave the `cgal/4.6.3-131/lib` part in the `rivet-config` and `rivet-build` scripts, which of course shouldn't be there. The right extraction should be ``` fastjet-config --libs | \ tr ' ' '\n' | \ grep cgal | \ sed -n 's|-L\(.*\)/lib|\1|p' ``` In this commit I also copy the original script (but disable the execute bit) for debugging purposes. We can of course remove that once we're happy.
Contributor
Author
|
jackal1-66
approved these changes
Jan 27, 2024
Contributor
jackal1-66
left a comment
jackal1-66
left a comment
There was a problem hiding this comment.
I checked the behaviour of the main edit and it's coherent with what you report.
Contributor
Author
|
Yours, |
Contributor
Author
|
@ktf Could this be merged even though Yours, |
ktf
reviewed
Jan 30, 2024
Contributor
Author
|
Testing the install > alienv enter Rivet/rivet-3.1.8-14
[Rivet/rivet-3.1.8-14] ~ > rivet-config --libs | tr ' ' '\n'
L/cvmfs/alice.cern.ch/el7-x86_64/Packages/HepMC3/3.2.5-112/lib
-lHepMC3
-lHepMC3search
-L/cvmfs/alice.cern.ch/el7-x86_64/Packages/YODA/yoda-1.9.7-9/lib
-lYODA
-L/cvmfs/alice.cern.ch/el7-x86_64/Packages/fastjet/v3.4.1_1.052-alice2-10/lib
-lfastjettools
-lfastjet
-lCGAL
-lgmp
-L/cvmfs/alice.cern.ch/el7-x86_64/Packages/cgal/4.6.3-131/lib
-L/cvmfs/alice.cern.ch/el7-x86_64/Packages/GMP/v6.2.1-43/lib
-Wl,-rpath,/cvmfs/alice.cern.ch/el7-x86_64/Packages/GMP/v6.2.1-43/lib
-lm
-lfastjetplugins
-lsiscone_spherical
-lsiscone
-lfastjetcontribfragile
-lfastjettools
-lRivetThat looks right. Let's try to build an analysis plug-in [Rivet/rivet-3.1.8-14] analyses > rivet-build ALICE_YYYY_I1234567.cc
Using default library name 'RivetAnalysis.so'
g++ -o "RivetAnalysis.so" -shared -fPIC -I/cvmfs/alice.cern.ch/el7-x86_64/Packages/Rivet/rivet-3.1.8-14/include -I/cvmfs/alice.cern.ch/el7-x86_64/Packages/HepMC3/3.2.5-112/include -DENABLE_HEPMC_3=true -I/usr/include -I/usr/include -I/cvmfs/alice.cern.ch/el7-x86_64/Packages/YODA/yoda-1.9.7-9/include -I/cvmfs/alice.cern.ch/el7-x86_64/Packages/fastjet/v3.4.1_1.052-alice2-10/include -pedantic -Wall -Wno-long-long -Wno-format -Werror=uninitialized -Werror=delete-non-virtual-dtor -fopenmp -fPIC -g -O2 -std=c++17 -Wl,--no-as-needed -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/cgal/4.6.3-131/lib -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/GMP/v6.2.1-43/lib -Wl,--no-as-needed -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/Rivet/rivet-3.1.8-14/lib -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/HepMC3/3.2.5-112/lib -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/YODA/yoda-1.9.7-9/lib -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/fastjet/v3.4.1_1.052-alice2-10/lib -lfastjettools -lfastjet -lCGAL -lgmp -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/cgal/4.6.3-131/lib -L/cvmfs/alice.cern.ch/el7-x86_64/Packages/GMP/v6.2.1-43/lib -Wl,-rpath,/cvmfs/alice.cern.ch/el7-x86_64/Packages/GMP/v6.2.1-43/lib -lm -lfastjetplugins -lsiscone_spherical -lsiscone -lfastjetcontribfragile -lfastjettools -lRivet ALICE_YYYY_I1234567.cc Yeah! That worked too. I think we can declare success - thank you all for your help and patience. Yours, |
Contributor
Author
|
BTW, you need to be explicit about the version to load: alienv enter RivetDo you know if there's a way to make Yours, |
Contributor
|
I also confirm that the fix was successful. Tested 4 jobs on the GRID and the build was performed without errors. Thanks for having looked into it @cholmcc and for the solution. |
MichaelLettrich
pushed a commit
to MichaelLettrich/alidist
that referenced
this pull request
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had
which would do
which would then leave the
cgal/4.6.3-131/libpart in therivet-configandrivet-buildscripts, which of course shouldn't be there. The right extraction should beIn this commit I also copy the original script (but disable the execute bit) for debugging purposes. We can of course remove that once we're happy.
See also this comment on #5230.
Yours,
Christian