Make some models require all keys in their underlying dictionaries#5657
Open
Make some models require all keys in their underlying dictionaries#5657
Conversation
quis
force-pushed
the
strict-json-model
branch
from
fbd2bde to
256ff93
Compare
quis
force-pushed
the
strict-json-model
branch
from
256ff93 to
1e7ff29
Compare
quis
force-pushed
the
strict-json-model
branch
2 times, most recently
from
47e14d9 to
5c05bbe
Compare
This will raise an error if one of the attributes is missing from the dictionary. This is the same way that the serialised models work in the API.
quis
force-pushed
the
strict-json-model
branch
from
5c05bbe to
08aa3b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will raise an error if one of the attributes is missing from the dictionary.
This is the same way that the serialised models work in the API.
This gives us more confidence that the mock data in the tests is realistic.
This pull request only does this for the less complicated models. More complicated ones can receive data from different sources and may not be always be initialised with data that has the same schema.