Conversation
robinjam
force-pushed
the
jar-otel
branch
24 times, most recently
from
4fadbf2 to
c0b9237
Compare
robinjam
force-pushed
the
jar-otel
branch
6 times, most recently
from
24c5c05 to
30b9b15
Compare
robinjam
force-pushed
the
jar-otel
branch
11 times, most recently
from
7fc3523 to
7f548fc
Compare
There's no real reason for this function to exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/25A3gpXh/1358-replace-statsd-instrumentation-across-notify-with-otel
Adds the following metrics, instrumented using OpenTelemetry (optional attributes are denoted like
[this]):notification.send.duration{[error.type], key.type, notification.type, [notification.sms.country_code], [notification.sms.international], provider.name}: The elapsed time between when a notification was created and when it was sent to a provider.notification.deliver.duration{key.type, notification.status, notification.type, [notification.sms.country_code], [notification.sms.international], provider.name}: Elapsed time between sending a notification to a provider and receiving a callback from that provider.provider.request.duration{[error.type], notification.type, [notification.sms.country_code], [notification.sms.international], provider.name}: The total time taken to make a request to a provider.When these are pushed to Prometheus by the OTel sidecar, their names and the names of their attributes will automatically be converted to match Prometheus naming conventions, e.g.
notification.send.duration{notification.type=...}becomesnotification_send_duration_seconds_bucket{notification_type=...}.These metrics are ultimately intended to replace all of the metrics we currently collect via StatsD (though this will require updating a bunch of dashboards).