Conversation
rparke
force-pushed
the
rp-add-queue-for-sendfiles-by-email-process-job-row-post-worker-rollout
branch
2 times, most recently
from
bf3fed7 to
0f1a63b
Compare
rparke
added a commit
that referenced
this pull request
Apr 1, 2026
adds branching logic to put `save-email` tasks with `has_documents` true onto the dedicated queue for emails with files, `database-tasks-documents` This needs deploying to all workers before #4795 can be deployed, otherwise workers will get called with an argument that they can't handle.
4 tasks
rparke
force-pushed
the
rp-add-queue-for-sendfiles-by-email-process-job-row-post-worker-rollout
branch
from
0f1a63b to
a46a4b1
Compare
rparke
changed the title
shatter-job-rows tasks with has_documents = True for email templates that have a file "attached" to them
rparke
added a commit
that referenced
this pull request
Apr 2, 2026
adds branching logic to put `save-email` tasks with `has_documents` true onto the dedicated queue for emails with files, `database-tasks-documents` This needs deploying to all workers before #4795 can be deployed, otherwise workers will get called with an argument that they can't handle.
CrystalPea
reviewed
Apr 2, 2026
Contributor
CrystalPea
left a comment
CrystalPea
left a comment
There was a problem hiding this comment.
Nice one, a couple comments:
…emplates that have a file "attached" to them calling `shatter-job-rows` like this will cause those `save_email` tasks to be put on the new `database-tasks-documents` queue and be picked up by a new dedicated worker, `api-worker-jobs-save-documents`
rparke
force-pushed
the
rp-add-queue-for-sendfiles-by-email-process-job-row-post-worker-rollout
branch
from
76d44c3 to
0d792c3
Compare
rparke
added a commit
that referenced
this pull request
Apr 2, 2026
adds branching logic to put `save-email` tasks with `has_documents` true onto the dedicated queue for emails with files, `database-tasks-documents` This needs deploying to all workers before #4795 can be deployed, otherwise workers will get called with an argument that they can't handle.
CrystalPea
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calling
shatter-job-rowslike this will cause thosesave_emailtasks to be put on the newdatabase-tasks-documentsqueue and be picked up by a new dedicated worker,api-worker-jobs-save-documentsTODO: