Skip to content

fix(hotkey): apply primary dictation shortcut change to live event tap #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devzahirul wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(hotkey): apply primary dictation shortcut change to live event tap #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Sources/Fluid/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,7 +1091,17 @@ struct ContentView: View {
shortcuts.append(shortcut)
}
}
self.primaryDictationShortcuts = shortcuts

// Persist and push the normalized list to the running event tap right here, mirroring the
// other shortcut types in applyRecordedShortcut(_:to:). GlobalHotkeyManager matches primary
// dictation against its cached `primaryShortcuts` array, so the previous shortcut keeps
// firing until this update runs. Doing it directly (instead of relying solely on the
// .onChange(of:) side effect, which is driven from the NSEvent capture callback) makes the
// replacement take effect without an app restart. (#470)
SettingsStore.shared.primaryDictationShortcuts = shortcuts
let storedShortcuts = SettingsStore.shared.primaryDictationShortcuts
self.primaryDictationShortcuts = storedShortcuts
self.hotkeyManager?.updatePrimaryShortcuts(storedShortcuts)
}

private func setShortcutTargetEnabled(_ enabled: Bool, for target: ShortcutRecordingTarget) {
Expand Down