Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t null Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Release bundle updating the Polydock Engine Laravel application with framework/dependency upgrades, API improvements (enums + instance provisioning inputs), and operational workflow additions for dev→prod releases.
Changes:
- Upgrade core dependencies (notably Laravel 12) and adjust framework configs/middleware accordingly.
- Extend authenticated API to expose selected enums and enhance instance creation to accept
nameand structuredsecretdata (including legacyconfig.secretsupport). - Improve webhook-safe data handling/redaction and add GitHub Actions workflows to support release PR creation and prod-branch protection.
Reviewed changes
Copilot reviewed 35 out of 37 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/Traits/HasWebhookSensitiveDataTest.php | Adds unit coverage for sensitive key filtering and registration. |
| tests/Feature/Filament/CreatePolydockAppInstanceTest.php | Tightens queue dispatch expectations for Filament admin instance creation. |
| tests/Feature/Api/RegionsApiTest.php | Updates assertions to match regions API payload shape (removes uuid). |
| tests/Feature/Api/AuthenticatedApiTest.php | Adds coverage for /api/enums, instance status fields, and instance create inputs (name, secret). |
| routes/api.php | Adds authenticated /api/enums route. |
| package-lock.json | Updates frontend/build dependencies. |
| config/session.php | Session cookie naming and secure cookie config adjustments. |
| config/horizon.php | Updates Horizon Redis key prefix format. |
| config/database.php | Updates Redis prefix format. |
| config/cache.php | Updates cache prefix format. |
| composer.lock | Updates PHP/Laravel and related dependency lock set. |
| composer.json | Bumps Laravel/framework and other PHP package versions. |
| bootstrap/app.php | Adds proxy trusting + middleware aliasing updates. |
| app/Traits/HasWebhookSensitiveData.php | Improves sensitive-key registration and regex matching behavior. |
| app/Traits/HasEnumOptions.php | Introduces a shared enum→options/value helper for API/UI use. |
| app/Providers/Filament/AppPanelProvider.php | Updates CSRF middleware class for newer Laravel versions. |
| app/Providers/Filament/AdminPanelProvider.php | Updates CSRF middleware class for newer Laravel versions. |
| app/Providers/AppServiceProvider.php | Secures Scramble OpenAPI document with bearer auth scheme. |
| app/Models/UserGroup.php | Adds slug fillable, slug creation logic, and instance allocation updates to support custom name input. |
| app/Models/PolydockStoreApp.php | Makes lagoon deploy private key accessor nullable. |
| app/Models/PolydockAppInstance.php | Removes shadowed $name property, enforces name uniqueness, and widens key/value storage retrieval types. |
| app/Http/Controllers/Api/RegionsController.php | Removes unused/always-null uuid field from regions payload. |
| app/Http/Controllers/Api/AuthenticatedApiController.php | Adds enums endpoint and expands instance create validation + secret handling + status payload fields. |
| app/Filament/Admin/Resources/PolydockAppInstanceResource/Pages/CreatePolydockAppInstance.php | Stops directly dispatching processing job (delegated to event/listener). |
| app/Filament/Admin/Resources/PolydockAppInstanceResource.php | Improves infolist display (App URL + key/value rendering with redaction). |
| app/Enums/UserRemoteRegistrationType.php | Adds shared enum options helper trait. |
| app/Enums/UserRemoteRegistrationStatusEnum.php | Adds shared enum options helper trait; removes custom options builder. |
| app/Enums/UserGroupRoleEnum.php | Adds shared enum options helper trait; removes custom options builder. |
| app/Enums/PolydockVariableScopeEnum.php | Adds shared enum options helper trait. |
| app/Enums/PolydockStoreWebhookCallStatusEnum.php | Adds shared enum options helper trait. |
| app/Enums/PolydockStoreStatusEnum.php | Adds shared enum options helper trait. |
| app/Enums/PolydockStoreAppStatusEnum.php | Adds shared enum options helper trait. |
| app/Console/Commands/RemoveAppInstancesByEmail.php | Minor formatting/flow tweaks for command output. |
| README.md | Documents dev branching and release workflow. |
| .github/workflows/release-button.yml | Adds manual workflow to open release PR from dev→prod. |
| .github/workflows/protect-prod-branch.yml | Adds enforcement that only dev/hotfix* can target prod. |
| .env.example | Adds SESSION_SECURE_COOKIE example setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this release:
698760d fix: use filled() instead of has() for secret check to handle explicit null
022fb38 Initial plan
d376b49 chore: update doc
666abec chore: handle null as empty
1d2a77b chore: bump deps
46bce27 chore: fix
127d6fa chore: default to empty string
ffba5a8 chore: inject ai key info via api/instance create
0b83a0b chore: bump to laravel 12
5627a30 chore: allow name to be passed in
89c73f3 chore: bump scramble
72cd9d8 chore: bump deps
dbde5c6 chore: output lagoon-project-name and claim-script-output
e9fdc00 chore: add github actions: protect prod, release trigger
0201553 chore: add note about dev workflow
19f2358 chore: grammar
6d449e9 chore: fix scramble
13a6d74 chore: refactor
2bb69f2 chore: improve scramble
f7749a6 chore: expose enums to api