Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds “stale job” handling to Polydock app-instance lifecycle jobs so that if a queued job runs after the instance has already progressed beyond the expected status, the job exits cleanly instead of throwing a status-flow exception.
Changes:
- Add
BaseJob::shouldSkipBecauseStatusAdvanced()with a hard-coded status progression list and use it across multiple lifecycle jobs. - Increase the
WithoutOverlappinglock expiration from 5s to 120s. - Add a feature test ensuring
ClaimJobskips when the instance is already in a running status.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Feature/Jobs/StaleLifecycleJobTest.php | Adds a feature test covering stale-ClaimJob skip behavior. |
| app/Jobs/ProcessPolydockAppInstanceJobs/BaseJob.php | Introduces shared stale-job skip logic and increases overlap lock TTL. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Claim/ClaimJob.php | Skips when instance status has already advanced beyond pending-claim. |
| app/Jobs/ProcessPolydockAppInstanceJobs/New/ProcessNewJob.php | Skips when instance has already advanced beyond NEW. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Create/PreCreateJob.php | Adds stale-job skip handling for pre-create. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Create/CreateJob.php | Adds stale-job skip handling for create. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Create/PostCreateJob.php | Adds stale-job skip handling for post-create. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Deploy/PreDeployJob.php | Adds stale-job skip handling for pre-deploy. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Deploy/DeployJob.php | Adds stale-job skip handling for deploy. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Deploy/PostDeployJob.php | Adds stale-job skip handling for post-deploy. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Remove/PreRemoveJob.php | Adds stale-job skip handling for pre-remove. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Remove/RemoveJob.php | Adds stale-job skip handling for remove. |
| app/Jobs/ProcessPolydockAppInstanceJobs/Remove/PostRemoveJob.php | Adds stale-job skip handling for post-remove. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/amazeeio/polydock-engine/sessions/3248445d-d7b5-4ba8-8c8a-da2406e6c1e9 Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/amazeeio/polydock-engine/sessions/9de00697-ca6a-47fd-aa5c-c78e1dde1814 Co-authored-by: dan2k3k4 <158704+dan2k3k4@users.noreply.github.com>
No description provided.