Add pin (pinocchio) to holosoma_inference install_requires#115
Open
kingb wants to merge 1 commit into
Open
Conversation
`holosoma_inference.policies.wbt_utils` imports `pinocchio as pin`, making `pin` a runtime dependency for the WBT policy code path. It's not currently declared in setup.py, so any environment that relies on pip's dep resolution to install holosoma_inference (vs. manually layering it in) hits an ImportError on first WBT use. Pin to >=3.8.0 to match the API surface used in wbt_utils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
holosoma_inference.policies.wbt_utilsimportspinocchio as pin, making it a runtime dependency for the WBT policy code path. It's not currently declared insrc/holosoma_inference/setup.py::install_requires, so any environment that relies on pip's dependency resolution to installholosoma_inference(rather than layering pinocchio in manually) hits an ImportError on the first WBT call.Pinned to
>=3.8.0to match the API surface used inwbt_utils.py.Why now
Came up in code review on a downstream Dockerfile that explicitly installs
pin>=3.8.0as a workaround. Adding it here removes the need for that workaround in every consumer.Test plan
pip install -e src/holosoma_inference[unitree]in a clean Python 3.12 venv now resolves and installspinautomatically.python -c "from holosoma_inference.policies.wbt_utils import *"no longer raisesModuleNotFoundError: No module named 'pinocchio'in a fresh install.