feat: Customizable Gravatar fallback#263
Open
cougrimes wants to merge 1 commit intoambassify:masterfrom
Open
Conversation
chore: Made Gravatar fallback parameter dynamic so it can be assigned as appropriate. Now defaults to blank instead of 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Gravatar has a hardcoded fallback to the
d=404parameter, meaning that any Gravatar images that can't be resolved will result in a 404 hit. As there may be times Gravatar is not expected to have 100% coverage, the ability to pass custom fallback parameters for default images makes sense as a feature extension.This code is intended to let
onErroroverride any behavior defined by thefallbackprop as to minimize issues.