Skip to content

Fix token exposure in frontend tool message display #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremyeder wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix token exposure in frontend tool message display #346

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3d74be
Fix token exposure in frontend tool message display
Nov 19, 2025
444b699
Address PR feedback: Improve token redaction patterns and add tests
Nov 19, 2025
16d11e4
fix: remove non-functional test file causing TypeScript errors
jeremyeder Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 35 additions & 9 deletions components/frontend/src/components/ui/tool-message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,39 @@ const formatToolName = (toolName?: string) => {
.join(" ");
};

const redactSecrets = (text: string): string => {
if (!text) return text;

// Redact GitHub tokens (ghs_, ghp_, gho_, ghu_ prefixes)
text = text.replace(/gh[pousr]_[a-zA-Z0-9]{36,255}/g, 'gh*_***REDACTED***');

// Redact x-access-token: patterns in URLs
text = text.replace(/x-access-token:[^@\s]+@/g, 'x-access-token:***REDACTED***@');

// Redact oauth tokens in URLs
text = text.replace(/oauth2:[^@\s]+@/g, 'oauth2:***REDACTED***@');

// Redact basic auth credentials in URLs
text = text.replace(/:\/\/[^:@\s]+:[^@\s]+@/g, '://***REDACTED***@');

// Redact Authorization header values (Bearer, token, etc.)
text = text.replace(/(Authorization["\s:]+)(Bearer\s+|token\s+)?([a-zA-Z0-9_\-\.]+)/gi, '$1$2***REDACTED***');

// Redact common API key patterns
text = text.replace(/(["\s])(sk-[a-zA-Z0-9]{20,})/g, '$1***REDACTED***');
text = text.replace(/(["\s])(api[_-]?key["\s:]+)([a-zA-Z0-9_\-\.]+)/gi, '$1$2***REDACTED***');
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Redaction misses tokens at start of string

The new redactSecrets patterns only match API key values that are preceded by whitespace or a quote, so a tool input/result that begins with a token (e.g., the entire content is sk-... or api_key=...) will bypass redaction and still be rendered in cleartext. Because the intent of this change is to prevent secret exposure, any tool output that is just a bare token remains unprotected due to the leading-character requirement in /(["\s])(sk-[a-zA-Z0-9]{20,})/ and /(["\s])(api[_-]?key["\s:]+)([a-zA-Z0-9_\-\.]+)/.

Useful? React with 👍 / 👎.


return text;
};

const formatToolInput = (input?: string) => {
if (!input) return "{}";
try {
const parsed = JSON.parse(input);
return JSON.stringify(parsed, null, 2);
const formatted = JSON.stringify(parsed, null, 2);
return redactSecrets(formatted);
} catch {
return input;
return redactSecrets(input);
}
};

Expand Down Expand Up @@ -145,7 +171,7 @@ const getColorClassesForName = (name: string) => {

const extractTextFromResultContent = (content: unknown): string => {
try {
if (typeof content === "string") return content;
if (typeof content === "string") return redactSecrets(content);
if (Array.isArray(content)) {
const texts = content
.map((item) => {
Expand All @@ -155,7 +181,7 @@ const extractTextFromResultContent = (content: unknown): string => {
return "";
})
.filter(Boolean);
if (texts.length) return texts.join("\n\n");
if (texts.length) return redactSecrets(texts.join("\n\n"));
}
if (content && typeof content === "object") {
// Some schemas nest under content: []
Expand All @@ -169,12 +195,12 @@ const extractTextFromResultContent = (content: unknown): string => {
return "";
})
.filter(Boolean);
if (texts.length) return texts.join("\n\n");
if (texts.length) return redactSecrets(texts.join("\n\n"));
}
}
return JSON.stringify(content ?? "");
return redactSecrets(JSON.stringify(content ?? ""));
} catch {
return String(content ?? "");
return redactSecrets(String(content ?? ""));
}
};

Expand Down Expand Up @@ -347,11 +373,11 @@ export const ToolMessage = React.forwardRef<HTMLDivElement, ToolMessageProps>(
>
<ExpandableMarkdown
className="prose-sm"
content={
content={redactSecrets(
typeof toolResultBlock?.content === "string"
? (toolResultBlock?.content as string)
: JSON.stringify(toolResultBlock?.content ?? "")
}
)}
/>
</div>
</div>
Expand Down
Loading