Open
Conversation
Two bugs:
1. design.py passed np.dtype[bfloat16] (a GenericAlias) as the kernel's
alpha parameter type, but MLIR expects a bare type. Fixed by changing
np.dtype[xfr_dtype] to xfr_dtype.
2. Missing AIE2 kernel, only the AIE2P version existed. Added
aie_kernels/aie2/leaky_relu.cc (vector width 16).
Also removed pytest.mark.skip from test and updated README.md to
reflect working status.
Contributor
📊 Test Results for Test Example Applications709cb99 (2026_04_10_17_04_11) IRONCLADTested on
📈 Trends (vs main branch) for Test Example Applications709cb99 (2026_04_10_17_04_11) IRONCLAD Trendsllama_3.2_1b
llama_3.2_1b_prompt_1024_tokens_1
llama_3.2_1b_prompt_1024_tokens_40
llama_3.2_1b_prompt_13_tokens_1
llama_3.2_1b_prompt_13_tokens_40
llama_3.2_1b_prompt_2048_tokens_1
llama_3.2_1b_prompt_2048_tokens_40
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
aie_kernels/aie2/leaky_relu.cc: AIE2 kernel for Leaky ReLU (vector width 16, matching the AIE2P version's structure withaie::API).Changed
iron/operators/leaky_relu/design.py: Fixed kernel parameter type:np.dtype[xfr_dtype]→xfr_dtype. The previous form produced aGenericAliasthat MLIR couldn't convert to a function type, causingTypeErrorduring compilation.iron/operators/leaky_relu/test.py: Removed@pytest.mark.skipdecorator.README.md: Updated Leaky RELU row: removed "(WIP)", added NPU1 support checkmark, changed status to green.Removed
Nothing.
Test results
PR Merge Checklist
develcommit and pointing todevel.Closes #36