[ENG-4159] Config/nest quota optimization in provider options - #386
Merged
AmandaYao00 merged 2 commits intoAug 5, 2026
Merged
Conversation
Replaces the object-level `salesforceQuotaOptimization` property (added in #381, unreleased) with `providerOptions.quotaOptimization`. Two reasons for the move: - Quota optimization is Salesforce-only, so at the top level of a subscribe config object it sits beside properties every provider honors and reads as generally available. `providerOptions` names the category, so the next provider-specific option is an addition rather than another outlier. - Dropping the `salesforce` prefix leaves room for other providers to support the same feature without a second schema. The Salesforce-only constraint is documented on the property and enforced by server validation, which is where it belongs — it can be relaxed without a schema revision. `SubscribeProviderOptions` is a named schema with declared properties rather than a free-form map, so each option is typed in generated clients and a misspelled option is a spec error instead of config the server silently drops. It is subscribe-scoped rather than shared, so read/write config objects can later declare their own options without advertising subscribe's. No migration: the property is not yet read by the server (the feature is still gated behind the hardcoded (projectId, groupRef) maps) and no backfill has run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
AmandaYao00
changed the title
AmandaYao00
deleted the
config/nest-quota-optimization-in-provider-options
branch
August 5, 2026 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.