fix(session-replay-browser): prevent multiple instances from starting#1294
Draft
jpollock-ampl wants to merge 1 commit intomainfrom
Draft
fix(session-replay-browser): prevent multiple instances from starting#1294jpollock-ampl wants to merge 1 commit intomainfrom
jpollock-ampl wants to merge 1 commit intomainfrom
Conversation
Comment on lines
+533
to
+536
| // NOTE: If there is already an active instance, do not start a new one | ||
| if (this.recordCancelCallback) { | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
I'll be curious to see how testing goes, but I'm wondering if this will break some assumptions about this function. Specifically, it's more of a start or restart recording events at the moment.
Collaborator
Author
There was a problem hiding this comment.
+1 - I will report back from testing. What are the scenarios in which we would want to restart? Focus changes?
Collaborator
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist