chore(analytics-react-native): update async-storage dependency to dev…#1355
Open
trbsdemir wants to merge 1 commit intoamplitude:mainfrom
Open
chore(analytics-react-native): update async-storage dependency to dev…#1355trbsdemir wants to merge 1 commit intoamplitude:mainfrom
trbsdemir wants to merge 1 commit intoamplitude:mainfrom
Conversation
… and peer dependencies
|
@Mercy811 (sorry to ping you but didn't found any alias for RN maintainers and you were the most active contributor) is there anything we can do to unblock this PR? this is an active issue if you have yourself installed @react-native-async-storage/async-storage as they released v2 already.
fixes #1367. |
|
is a peer dependency the right direction here? can we just upgrade the dependency to v2? would love to ship this fix as it's blocking my own Expo upgrade. |
Contributor
|
Guys... Come on... Merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change: Added @react-native-async-storage/async-storage as peer (>=1.17.11) and dev (^1.17.11) deps in packages/analytics-react-native/package.json.
Impact: No code changes; consumers must have async-storage >=1.17.11 installed.
After this PR, developers can install any version of async-storage they want. Due to React Native auto-linking, this is not just a warning — it actually causes compilation errors.