🐛 Escape attribute values and text content in getHtml#40534
Open
madib06ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHtml assembles an HTML string by hand and writes attribute values and text nodes into it unescaped, so any host-page value carrying a quote or angle bracket escapes the markup it is serialized into: a title of x" onmouseover="evil() comes back as a live event handler, and a text node holding
comes back as real markup. An ad iframe reaches this through the GET_HTML message when the slot sets data-html-access-allowed, and the serialized string is returned to that frame. Escaping both sinks with escapeHtml matches what the friendly-iframe-embed serializer already does and leaves plain values untouched, so the existing tests are unaffected.