-
Notifications
You must be signed in to change notification settings - Fork 20
T1L and SPOE boards #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
T1L and SPOE boards #100
Conversation
|
Hi aron, please renormalize your branch to use git lfs, this ensures it is snappy for everyone in the longterm |
|
I cannot add @aronkis as a contributor of the repo. Do you have your SSO correlated with that account? |
|
@gastmaier SSO is now correlated with this account. |
|
Hi @gastmaier , Thank you for your help! Regards, |
Add user guide for the EVAL-AD4130-8-PMDZ evaluation board, a compact 8-channel 24-bit sigma-delta ADC with PGA and FIFO in PMOD format. Signed-off-by: Aron Kis <kis.aron@analog.com>
|
Hi, please don't generate merge commits like this. It is ok to do once or twice if it is intentional (e.g. create a merge commit with another branch with the intent of showing it as interdependent). I ended up raw checking out the head commit and recreating the commits since rebasing on main was impossible... I suppose the actual edit files are under: After the head checkout and initial commits, claude helped me, using the prompts: Then then I went back to each commit and reviewed. Then Then compare the changes with you head. |
|
Please, now do a self-review of the changes. Especially added links that does not exist. |
9623487 to
cb808d6
Compare
gastmaier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force pushed to --autosquash the --fixup commits
gastmaier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, focus on providing valid links to the source code.
Blind testing, I quickly found one that is broken
| evaluation board to **P2** on the | ||
| :adi:`AD-T1LUSB2.0-EBZ <ad-t1lusb20-ebz>` evaluation board. | ||
|
|
||
| #. Upload the :git-no-OS:`AD-APARD32690-SL ADIN2111 Example <projects/ASWPF/src/examples/adin2111_example/>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this does not exist in the no-OS main branch, cannot find a branch that relates to this and the upper case path is very suspicious, am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is missing, I'm currently working on a PR to add this project to NO-OS. You can see it here. I will have to change the path today, so it will be <projects/apardpfwd>. This link was meant only as a placeholder.
Add user guide for the AD-RPI-T1LPSE-SL, a 2-port 10BASE-T1L field switch with Single Pair Power over Ethernet PSE for Raspberry Pi. Signed-off-by: Aron Kis <kis.aron@analog.com>
Add user guide for the AD-APARDSPOE-SL, a 10BASE-T1L power extractor Arduino shield with Single Pair Power over Ethernet powered device support. Signed-off-by: Aron Kis <kis.aron@analog.com>
Add user guide for the AD-APARDPFWD-SL, a 2-port 10BASE-T1L Arduino shield with Single Pair Power over Ethernet power forwarding capability. Signed-off-by: Aron Kis <kis.aron@analog.com>
Update pin descriptions and specifications CSV files. Update index formatting. Signed-off-by: Aron Kis <kis.aron@analog.com>
|
Changed the apardpfwd to the correcet path. |

Type
Checklist
make htmloradoc serve: