test(chapterview): split critical flows + add inline edit#20
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split ChapterView critical-flow tests to keep jsdom coverage focused and add a dedicated inline-edit flow test.
Changes
Testing
�[1m�[46m RUN �[49m�[22m �[36mv4.0.16 �[39m�[90m/Users/aditya/Documents/Ongoing Local/LexiconForge�[39m
�[32m✓�[39m tests/integration/ChapterView.inline-edit.test.tsx �[2m(�[22m�[2m1 test�[22m�[2m)�[22m�[33m 363�[2mms�[22m�[39m
�[33m�[2m✓�[22m�[39m edits a selected chunk and persists via TranslationPersistenceService �[33m 362�[2mms�[22m�[39m
�[32m✓�[39m tests/integration/ChapterView.critical-flows.test.tsx �[2m(�[22m�[2m2 tests�[22m�[2m)�[22m�[32m 63�[2mms�[22m�[39m
�[2m Test Files �[22m �[1m�[32m2 passed�[39m�[22m�[90m (2)�[39m
�[2m Tests �[22m �[1m�[32m3 passed�[39m�[22m�[90m (3)�[39m
�[2m Start at �[22m 01:17:23
�[2m Duration �[22m 989ms�[2m (transform 523ms, setup 147ms, import 555ms, tests 427ms, environment 662ms)�[22m