fix(teleport): reject negative message length in Unpack to avoid panic#138
Open
SAY-5 wants to merge 1 commit into
Open
fix(teleport): reject negative message length in Unpack to avoid panic#138SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
Protocol.Unpackreads the message length from the packet header as a signed int32 viaBytesToInt. When a malformed packet carries a negative length, the existinglength < ...+messageLengthguard passes (the right side shrinks), so the code slicesbuffer[start : start+messageLength]with a high bound below the low bound and panics withslice bounds out of range.Added a
messageLength < 0check to the same guard so a bad length is treated like a short buffer and the loop breaks, leaving the bytes inbufferOver. Added a regression test that panics without the guard.