fix: #543 more properly identify CREATE TABLE ... LIKE ... statements#767
Open
markjm wants to merge 2 commits intoandialbrecht:masterfrom
Open
fix: #543 more properly identify CREATE TABLE ... LIKE ... statements#767markjm wants to merge 2 commits intoandialbrecht:masterfrom
markjm wants to merge 2 commits intoandialbrecht:masterfrom
Conversation
945c80c to
8362373
Compare
Author
|
cc @reata who opened the relevant issue and @andialbrecht as the maintainer of this awesome project :) |
markjm
commented
Mar 12, 2024
markjm
commented
Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 97.04% 97.06% +0.01%
==========================================
Files 20 20
Lines 1558 1566 +8
==========================================
+ Hits 1512 1520 +8
Misses 46 46 ☔ View full report in Codecov by Sentry. |
Author
|
@andialbrecht resolved merge conflicts with recently merged #740 |
Author
|
Hi @andialbrecht just wanted to check in on this change. Is this something you would be interested in incorporating? If so, i can keep the branch conflict-free |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #543.
By skipping over setting
LIKEstatements as Comparisons during lexing phase. We then more thoroughly check its usage during grouping. If we are creating a TABLE (identified based on the rigid syntax documented here https://dev.mysql.com/doc/refman/8.0/en/create-table-like.html), then dont group as a Comparison, otherwise treat it as we did before.pytest)flake8)