Skip to content

Added WaitingRoom to room package#1

Merged
andreimerlescu merged 33 commits into
mainfrom
feature/start
Apr 13, 2026
Merged

Added WaitingRoom to room package#1
andreimerlescu merged 33 commits into
mainfrom
feature/start

Conversation

@andreimerlescu
Copy link
Copy Markdown
Owner

The room page is designed to hold rooms in them. The first room that I can think of is the WaitingRoom. Therefore, the WaitingRoom is the feature/start of the room package.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new Go module github.com/andreimerlescu/room providing a FIFO “waiting room” middleware intended for Gin applications, backed by a semaphore and a ticket/token mechanism to queue excess requests.

Changes:

  • Added core WaitingRoom types and Gin middleware implementation.
  • Added module scaffolding (go.mod, CI workflow, Makefile, versioning, docs/license).
  • Documented intended public API and usage patterns in README.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
types.go Defines WaitingRoom struct, token store, and status response shape.
room.go Implements middleware flow, ticket gating, HTML serving, and token generation.
new.go Adds constructors and Init/Stop lifecycle wiring.
README.md Documents library purpose and API surface.
go.mod Declares module, Go version, and dependencies (Gin, sema).
.github/workflows/go.yml Adds CI for vet/test-race/bench.
Makefile Provides local test/lint/bench/fuzz targets.
errors.go / const.go Adds error types and configuration constants.
LICENSE / VERSION / .gitignore Project metadata and housekeeping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread new.go
Comment thread new.go
Comment thread new.go
Comment thread room.go Outdated
Comment thread room.go
Comment thread room.go
Comment thread room.go Outdated
Comment thread README.md
Comment thread room.go
Comment thread room.go Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 15 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread room.go Outdated
Comment thread room.go Outdated
Comment thread room.go Outdated
Comment thread reaper.go
Comment thread room.go Outdated
Comment thread errors.go
Comment thread go.mod
Comment thread .github/workflows/go.yml Outdated
Comment thread room.go Outdated
Comment thread room.go
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread room.go Outdated
Comment thread room.go
Comment thread types.go Outdated
Comment thread status.go
Comment thread room.go
Comment thread README.md Outdated
Comment thread types.go Outdated
andreimerlescu and others added 6 commits April 12, 2026 23:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…g to proper atomic/mutex usage, recovers phantom tickets on error paths, and centralizes position calculation
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread new.go
Comment thread new.go
Comment thread reaper.go
Comment thread reaper.go Outdated
Comment thread room.go Outdated
Comment thread waiting_room.html Outdated
Comment thread README.md
Comment thread README.md Outdated
@andreimerlescu andreimerlescu merged commit b4b3ef9 into main Apr 13, 2026
1 check passed
@andreimerlescu andreimerlescu deleted the feature/start branch April 13, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants