Add a way to customize which json library to use#2
Open
jnylen wants to merge 1 commit intoandrewtimberlake:masterfrom
Open
Add a way to customize which json library to use#2jnylen wants to merge 1 commit intoandrewtimberlake:masterfrom
jnylen wants to merge 1 commit intoandrewtimberlake:masterfrom
Conversation
andrewtimberlake
force-pushed
the
master
branch
2 times, most recently
from
f68b655 to
1f8e0e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have started using Jsonrs everywhere where json encoding and decoding is used as it's way faster and more performant than Jason or Poison. I have seen a performance boost of around 500% just by replacing it with this.
So locking it to Jason and Poison in this hex feels a bit odd. So my PR adds a way to customize this. As well as renaming it to json library as this is the way it's named in PHX and other hexes.