Sync latest changes from main branch into prototype-ai-glasses by kathleenalexandra24 · Pull Request #170 · android/ai-samples

kathleenalexandra24 · 2026-05-08T15:48:39Z

No description provided.

gemini-code-assist

Code Review

This pull request introduces support for Google AI Glasses to the Gemini Live Todo sample, adding a new GlassesActivity and a dedicated UI built with Jetpack Compose Glimmer. The update includes integrating the androidx.xr libraries, updating the TodoRepository to manage microphone status as a list item, and adding a launch mechanism from the main TodoScreen. Feedback focuses on architectural improvements, such as removing Activity references from the ViewModel to adhere to style guides, eliminating redundant code and duplicate constants, and ensuring consistency between the documentation and the implementation regarding model IDs. Additionally, it was noted that some composables are missing Modifier parameters and that permission-related annotations are applied non-standardly.

gemini-code-assist · 2026-05-08T15:49:58Z

 class TodoScreenViewModel @Inject constructor(private val todoRepository: TodoRepository) : ViewModel() {
    private val TAG = "TodoScreenViewModel"
    private var session: LiveSession? = null
+    private var hostActivityRef: WeakReference<Activity>? = null


The ViewModel is holding a WeakReference to an Activity. This violates the 'Strongly recommended' architectural guidelines (Repository Style Guide, line 58), which state that ViewModels should be agnostic of the Android lifecycle and avoid references to Activities. This can lead to memory leaks and makes the ViewModel harder to test. Consider handling permission requests and session triggers in the UI layer.

References

ViewModels should be agnostic of the Android lifecycle. Avoid references to lifecycle-related types, Activities, Fragments, Context, or Resources. ^(link)

gemini-code-assist · 2026-05-08T15:49:58Z

+Read more about the Gemini Live API in the Android Documentation.
+Read more about the [Gemini Live API](https://developer.android.com/ai/gemini/live) in the Android Documentation.


There are duplicate 'Read more' links at the end of the file. Please remove the redundant line.

Suggested change

Read more about the Gemini Live API in the Android Documentation.

Read more about the [Gemini Live API](https://developer.android.com/ai/gemini/live) in the Android Documentation.

Read more about the [Gemini Live API](https://developer.android.com/ai/gemini/live) in the Android Documentation.

gemini-code-assist · 2026-05-08T15:49:58Z

+                statusText = "Mic Status",
+                isMicOn = false
+            ),
+        ).filterNot { it.id == MIC_STATUS_TODO_ID },


The filterNot call is redundant here because none of the items in the hardcoded list above have an ID matching MIC_STATUS_TODO_ID (-999).

Suggested change

).filterNot { it.id == MIC_STATUS_TODO_ID },

),

gemini-code-assist · 2026-05-08T15:49:58Z

+private const val MaxItemsInList = 4
+private val IconSize = 30.dp
+private const val TAG = "GlimmerTodoScreen"
+private const val MIC_CONTROL_ID = 111


The constant MIC_CONTROL_ID is duplicated here and in TodoScreenViewModel.kt. It is already defined as MIC_TODO_ID in Todo.kt. Please import and use the existing constant to maintain a single source of truth.

gemini-code-assist · 2026-05-08T15:49:58Z

+}
+
+@Composable
+private fun GlimmerScreenContent(


This composable function is missing a Modifier parameter. According to the Repository Style Guide (line 50), every composable function (except top-level ones) should take a Modifier as its first optional parameter.

References

Every composable function (except top level screen composable) should take a Modifier as a parameter with a default value. It should be positionned as the first optional parameter. ^(link)

gemini-code-assist · 2026-05-08T15:49:58Z

        requestAudioPermissionIfNeeded(activity)
+
+        viewModelScope.launch {
+            todoRepository.todos.collect @androidx.annotation.RequiresPermission(android.Manifest.permission.RECORD_AUDIO) { todos ->


The @RequiresPermission annotation is applied to a lambda expression here. This is non-standard and likely won't be correctly processed by lint tools for enforcement. Permission checks should be performed in the UI layer before calling ViewModel methods that require them.

gemini-code-assist · 2026-05-08T15:49:58Z

-            val generativeModel = Firebase.ai(backend = GenerativeBackend.googleAI()).liveModel(
-                "gemini-2.5-flash-native-audio-preview-12-2025",
+            val generativeModel = Firebase.ai(backend = GenerativeBackend.vertexAI()).liveModel(
+                "gemini-live-2.5-flash-preview-native-audio-09-2025",


The model ID gemini-live-2.5-flash-preview-native-audio-09-2025 used here is inconsistent with the model ID mentioned in the README (gemini-2.0-flash-live-preview-04-09). Please ensure the code and documentation are synchronized.

JolandaVerhoef

I don't really know if these are actually the changes you meant to make for adding the audio experience? It's very confusing. I'd like to review just the audio changes, not any other AI Glasses related changes. But this pull request seems to combine them?

JolandaVerhoef · 2026-05-08T16:06:59Z

 * You may obtain a copy of the License at
 *
- *     https://www.apache.org/licenses/LICENSE-2.0
+ * https://www.apache.org/licenses/LICENSE-2.0


don't change the copyright header

JolandaVerhoef · 2026-05-08T16:07:41Z

 * You may obtain a copy of the License at
 *
- *     https://www.apache.org/licenses/LICENSE-2.0
+ * https://www.apache.org/licenses/LICENSE-2.0


don't change the copyright header

JolandaVerhoef · 2026-05-08T16:10:13Z

 android {
    namespace = "com.android.ai.samples.geminilivetodo"
-    compileSdk = 35
+    compileSdk = 36


why does this need to be updated?

JolandaVerhoef · 2026-05-08T16:10:42Z


 ```kotlin
 val generativeModel = Firebase.ai(backend = GenerativeBackend.vertexAI()).liveModel(
-    "gemini-2.5-flash-native-audio-preview-12-2025",


This seems older?

JolandaVerhoef · 2026-05-08T16:11:03Z

@@ -1,13 +1,15 @@
-# Gemini Live Todo Sample
+# Gemini Live Todo AI Glasses Sample


do you really want to change the documentation of the whole todo app?

JolandaVerhoef · 2026-05-08T16:11:46Z

-
+    implementation(libs.androidx.xr.glimmer)
+    implementation(libs.androidx.xr.projected)
+    implementation("com.google.firebase:firebase-ai:17.5.0")


how did the live sample not yet have a firebase import?

JolandaVerhoef · 2026-05-08T16:21:50Z

Refer to #168 instead

lethargicpanda and others added 9 commits December 1, 2025 08:56

Update copy in ReadMe and Resource (#138)

e30b894

Update live model version (#145)

3638799

Update static assets URLs (#147)

06167f5

Imagen model update (#150)

8e6dacb

Add hybrid SDK sample (#153)

fee369b

Migrate Magic Selfie to Nano Banana2 (#157)

727f69c

Update Firebase AI Logic (#162)

b77a2bb

Remove Imagen samples and add Nano banana image generation (#165)

177aaa6

Sync latest changes from main branch into prototype-ai-glasses

4c74c2f

kathleenalexandra24 requested review from JolandaVerhoef, calren, ksemenova and lethargicpanda as code owners May 8, 2026 15:48

gemini-code-assist Bot reviewed May 8, 2026

View reviewed changes

kathleenalexandra24 changed the base branch from main to prototype-ai-glasses May 8, 2026 16:04

JolandaVerhoef reviewed May 8, 2026

View reviewed changes

JolandaVerhoef closed this May 8, 2026

		Read more about the Gemini Live API in the Android Documentation.
		Read more about the [Gemini Live API](https://developer.android.com/ai/gemini/live) in the Android Documentation.

		@@ -1,13 +1,15 @@
		# Gemini Live Todo Sample
		# Gemini Live Todo AI Glasses Sample

Conversation

kathleenalexandra24 commented May 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef left a comment

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef May 8, 2026

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef May 8, 2026

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef May 8, 2026

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef May 8, 2026

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef May 8, 2026

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef May 8, 2026

Choose a reason for hiding this comment

Uh oh!

JolandaVerhoef commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants