Skip to content

Fix README code examples + Extension.kt error messages #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomasbuilds wants to merge 2 commits into from
Closed

Fix README code examples + Extension.kt error messages #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb21b6b
Update README example code to actually compile
thomasbuilds Apr 28, 2026
0210487
Fix error messsages
thomasbuilds Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ when verifying. For example, if you expect the challenge to be equal to

```kotlin
// Create a ChallengeChecker
val challengeChecker = ChallengeMatcher("challenge123")
val challengeChecker = ChallengeMatcher(ByteString.copyFromUtf8("challenge123"))

// Verify an attestation certificate chain with the checker
val result = verifier.verify(certificateChain, challengeChecker)
Expand All @@ -57,9 +57,14 @@ with an `InMemoryLruCache` like in this sample:
```kotlin
val cacheSize = 100

// Create a ChainedChallengeChecker with desired ChallengeCheckers
// Create a ChainedChallengeChecker with desired ChallengeCheckers. The
// coroutineScope is used to run each individual checker.
val challengeChecker =
ChainedChallengeChecker.of(ChallengeMatcher("expectedChallenge"), InMemoryLruCache(cacheSize))
ChainedChallengeChecker.of(
coroutineScope,
ChallengeMatcher(ByteString.copyFromUtf8("expectedChallenge")),
InMemoryLruCache(cacheSize),
)

// Verify an attestation certificate chain with the checker
val result = verifier.verify(certificateChain, challengeChecker)
Expand Down
6 changes: 4 additions & 2 deletions src/main/kotlin/Extension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,9 @@ data class PatchLevel(val yearMonth: YearMonth, val version: Int? = null) {
partitionName: String = "",
logFn: (String) -> Unit = { _ -> },
): PatchLevel? {
check(patchLevel is ASN1Integer) { "Must be an ASN1Integer, was ${this::class.simpleName}" }
check(patchLevel is ASN1Integer) {
"Must be an ASN1Integer, was ${patchLevel::class.simpleName}"
}
Comment on lines +539 to +541
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using check here throws an IllegalStateException, which is inconsistent with other ASN.1 parsing methods in this file that throw ExtensionParsingException. More importantly, ASN1Converter.parse (used to parse patch levels in AuthorizationList.from) only catches ExtensionParsingException. If an IllegalStateException is thrown, it will cause the entire verification process to crash instead of gracefully logging the error and returning null for the malformed tag.

Suggested change
check(patchLevel is ASN1Integer) {
"Must be an ASN1Integer, was ${patchLevel::class.simpleName}"
}
if (patchLevel !is ASN1Integer) {
throw ExtensionParsingException("Must be an ASN1Integer, was ${patchLevel::class.simpleName}")
}

return from(patchLevel.value.toString(), partitionName, logFn)
}

Expand Down Expand Up @@ -768,7 +770,7 @@ private inline fun <reified T> ASN1Encodable.toSet(): Set<T> {
return this.map {
if (it !is T) {
throw ExtensionParsingException(
"Object must be a ${T::class.simpleName}, was ${this::class.simpleName}"
"Object must be a ${T::class.simpleName}, was ${it::class.simpleName}"
)
}
it
Expand Down