Skip to content

fix(@schematics/angular): warn when production configuration is missing for service worker #32400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Jan 30, 2026
Merged

fix(@schematics/angular): warn when production configuration is missing for service worker #32400

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
182d75d
fix(@schematics/angular): warn when production configuration is missi…
alan-agius4 Jan 30, 2026
1f90f1f
fixup! fix(@schematics/angular): warn when production configuration i…
alan-agius4 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/schematics/angular/service-worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ function getTsSourceFile(host: Tree, path: string): ts.SourceFile {
}

const serviceWorkerSchematic: RuleFactory<ServiceWorkerOptions> = createProjectSchematic(
async (options, { project, workspace, tree }) => {
async (options, { project, workspace, tree, logger }) => {
if (project.extensions.projectType !== 'application') {
throw new SchematicsException(`Service worker requires a project type of "application".`);
}
Expand All @@ -126,6 +126,11 @@ const serviceWorkerSchematic: RuleFactory<ServiceWorkerOptions> = createProjectS
const productionConf = buildTarget.configurations?.production;
if (productionConf) {
productionConf.serviceWorker = ngswConfigPath;
} else {
logger.warn(
'No "production" configuration found for build target. ' +
`The "serviceWorker" option with a value of "${ngswConfigPath}" will need to be set manually.`,
);
}
} else {
buildOptions.serviceWorker = true;
Expand Down
Loading