Skip to content

build: update aspect_rules_js to 3.0.2#32724

Merged
alan-agius4 merged 1 commit intoangular:21.2.xfrom
alan-agius4:bazel-cherry-pick
Mar 9, 2026
Merged

build: update aspect_rules_js to 3.0.2#32724
alan-agius4 merged 1 commit intoangular:21.2.xfrom
alan-agius4:bazel-cherry-pick

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

This updates the major version of aspect_rules_js.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 9, 2026
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Mar 9, 2026
@ngbot
Copy link
Copy Markdown

ngbot bot commented Mar 9, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure conflicts with base branch "21.2.x"
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates aspect_rules_js to version 3.0.2, a new major version. The changes include updating Bazel dependencies in MODULE.bazel, replacing the deprecated aspect_bazel_lib with bazel_lib and jq.bzl, and adjusting various build files and scripts to be compatible with the new version. Notably, environment variable checks for Bazel's runfiles directory have been updated, and ng-packagr resolution has been made more robust. Test assets have also been refactored. The changes appear to be a correct and complete migration to the new dependency version.

This updates the major version of `aspect_rules_js`.
@alan-agius4 alan-agius4 merged commit 3af71f9 into angular:21.2.x Mar 9, 2026
35 checks passed
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the bazel-cherry-pick branch March 9, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants