Skip to content

build: add @bazel/ibazel as a dev dependency#32808

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
hawkgs:add-ibazel
Mar 26, 2026
Merged

build: add @bazel/ibazel as a dev dependency#32808
alan-agius4 merged 1 commit intoangular:mainfrom
hawkgs:add-ibazel

Conversation

@hawkgs
Copy link
Member

@hawkgs hawkgs commented Mar 20, 2026

Add @bazel/ibazel as a dev dependency to the workspace root.

Can be handy for test-driven development and/or testing.

@hawkgs hawkgs requested review from alan-agius4 and clydin March 20, 2026 14:59
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 20, 2026
@hawkgs
Copy link
Member Author

hawkgs commented Mar 20, 2026

Should we add test-watch npm script to point to the potential contributors that this is available?

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds @bazel/ibazel as a dev dependency to the workspace root. The changes include modifications to package.json and pnpm-lock.yaml to include the new dependency and update related dependency versions.

@alan-agius4
Copy link
Collaborator

Should we add test-watch npm script to point to the potential contributors that this is available?

I don’t think that would too useful, as users would need to provide the test target, as it’s highly unlikely users would want to run all the tests in the repo.

@hawkgs
Copy link
Member Author

hawkgs commented Mar 23, 2026

Yeah, I agree it's not that useful. It's more of a "we have this available" rather than "use this when testing". Anyway, I am totally fine with not adding this to the scripts.

On another note, do we need to address the Gemini comments given the change is a result of pnpm add?

@alan-agius4
Copy link
Collaborator

Yeah, I agree it's not that useful. It's more of a "we have this available" rather than "use this when testing". Anyway, I am totally fine with not adding this to the scripts.

On another note, do we need to address the Gemini comments given the change is a result of pnpm add?

No please ignore.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: minor This PR is targeted for the next minor release labels Mar 24, 2026
@hawkgs hawkgs removed the request for review from clydin March 24, 2026 11:21
@hawkgs hawkgs removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 24, 2026
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 26, 2026
@ngbot
Copy link

ngbot bot commented Mar 26, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure conflicts with base branch "main"
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Mar 26, 2026
Add `@bazel/ibazel` as a dev dependency to the workspace root.
@angular-robot angular-robot bot requested a review from alan-agius4 March 26, 2026 13:21
@hawkgs hawkgs added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 26, 2026
@alan-agius4 alan-agius4 merged commit 2320ba8 into angular:main Mar 26, 2026
62 of 64 checks passed
@alan-agius4
Copy link
Collaborator

This PR was merged into the repository. The changes were merged into the following branches:

@hawkgs hawkgs deleted the add-ibazel branch March 26, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants