test: ignore HMR disabled console errors#32820
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly ignores the 'Hot Module Replacement is disabled' console error in e2e tests, preventing test failures when HMR is not active. The implementation is straightforward. I've added one suggestion to extract the hardcoded error message into a constant to improve code maintainability.
The e2e test utility now ignores browser console errors containing the string "Hot Module Replacement is disabled". This prevents tests from failing when running with HMR disabled.
0831bad to
b239313
Compare
clydin
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e test utility now ignores browser console errors containing the string "Hot Module Replacement is disabled". This prevents tests from failing when running with HMR disabled.