feat(@angular/cli): support custom port in MCP devserver start tool#32855
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Mar 27, 2026
Merged
feat(@angular/cli): support custom port in MCP devserver start tool#32855alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
amishne
added
area: @angular/cli
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to specify a port number for the development server and adds a utility to check port availability. The feedback identifies a potential race condition in the port check implementation where the promise resolves before the test server is fully closed, and points out an unused import in the test suite.
packages/angular/cli/src/commands/mcp/tools/devserver/devserver_spec.ts
Outdated
Show resolved
Hide resolved
dgp1130
approved these changes
Mar 27, 2026
Comment on lines
+63
to
+73
| let port: number; | ||
| if (input.port) { | ||
| if (!(await context.host.isPortAvailable(input.port))) { | ||
| throw new Error( | ||
| `Port ${input.port} is unavailable. Try calling this tool again without the 'port' parameter to auto-assign a free port.`, | ||
| ); | ||
| } | ||
| port = input.port; | ||
| } else { | ||
| port = await context.host.getAvailablePort(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Nit: Consider moving this into a function to reduce mutations.
const port = getPort(input, context);| fail('Should have thrown an error'); | ||
| } catch (e) { | ||
| expect((e as Error).message).toContain( | ||
| "Port 55555 is unavailable. Try calling this tool again without the 'port' parameter to auto-assign a free port.", |
Collaborator
There was a problem hiding this comment.
Consider: The agent can also just pick a different point. Maybe "Try using a different port or omitting the port parameter to auto-assign a free port."
Collaborator
alan-agius4
added
target: minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents tend to recreate the devserver frequently instead of keeping it alive, plus getting a random port each time can be annoying. This change slightly changes the descriptions, and adds an optional
portparameter, to prevent these two problems.This is a "feature" but a very small one, plus done to an experimental capability to start with, so patch is okay.