Skip to content

fix(@angular/build): preserve error stack traces during prerendering #32864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maruthang wants to merge 1 commit into from
Closed

fix(@angular/build): preserve error stack traces during prerendering #32864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/angular/build/src/utils/server-rendering/prerender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,12 @@ export async function prerenderPages(
sourcemap,
outputMode,
).catch((err) => {
assertIsError(err);

return {
errors: [`An error occurred while extracting routes.\n\n${err.message ?? err.stack ?? err}`],
errors: [
`An error occurred while extracting routes.\n\n${err.stack ?? err.message ?? err.code ?? err}`,
],
serializedRouteTree: [],
appShellRoute: undefined,
};
Expand Down Expand Up @@ -265,8 +269,9 @@ async function renderPages(
}
})
.catch((err) => {
assertIsError(err);
errors.push(
`An error occurred while prerendering route '${route}'.\n\n${err.message ?? err.stack ?? err.code ?? err}`,
`An error occurred while prerendering route '${route}'.\n\n${err.stack ?? err.message ?? err.code ?? err}`,
);
void renderWorker.destroy();
Comment on lines 273 to 276
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure type safety and for consistency with other error handling in this file (e.g., line 370), consider adding assertIsError(err) at the beginning of this catch block. This will guarantee that err is an Error object before its properties are accessed.

          assertIsError(err);
          errors.push(
            "An error occurred while prerendering route '" + route + "'.\n\n" + (err.stack ?? err.message ?? err.code ?? err),
          );
          void renderWorker.destroy();

});
Expand Down Expand Up @@ -371,7 +376,7 @@ async function getAllRoutes(

return {
errors: [
`An error occurred while extracting routes.\n\n${err.message ?? err.stack ?? err.code ?? err}`,
`An error occurred while extracting routes.\n\n${err.stack ?? err.message ?? err.code ?? err}`,
],
serializedRouteTree: [],
};
Expand Down
Loading