fix(@angular/build): prepend deploy-url to file loader output paths#32866
Closed
maruthang wants to merge 1 commit intoangular:mainfrom
Closed
fix(@angular/build): prepend deploy-url to file loader output paths#32866maruthang wants to merge 1 commit intoangular:mainfrom
maruthang wants to merge 1 commit intoangular:mainfrom
Conversation
Pass the publicPath option through to esbuild's common options so that assets processed by the file loader (e.g., SVGs imported via URL) get the deploy-url prefix applied, matching the previous webpack behavior. Fixes angular#32789
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds support for prepending the deploy URL to file loader import URLs by passing the publicPath option to the esbuild configuration. A new test case was added to verify that deployUrl is correctly applied to assets handled by the file loader. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Assets processed by esbuild's file loader (e.g., SVGs imported via
import svgUrl from './test.svg') do not get thedeploy-urlprefix applied. This is a regression from the webpack migration.Issue Number: #32789
What is the new behavior?
Pass the
publicPathoption through to esbuild's common options so that file loader output paths are correctly prefixed with the deploy-url value (e.g.,https://example.com/some/path/media/test.svg).Does this PR introduce a breaking change?