fix(@angular/build): correct zoneless app detection with polyfills array#32867
Closed
maruthang wants to merge 1 commit intoangular:mainfrom
Closed
fix(@angular/build): correct zoneless app detection with polyfills array#32867maruthang wants to merge 1 commit intoangular:mainfrom
maruthang wants to merge 1 commit intoangular:mainfrom
Conversation
The isZonelessApp check incorrectly treated any polyfill entry with a file extension as zone.js being present. This caused apps with custom polyfill files (e.g., ./polyfill-buffer.ts) but no zone.js to be incorrectly detected as non-zoneless. Now only checks for the literal 'zone.js' string. Fixes angular#30689
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refines the isZonelessApp utility by removing the regex check for script file extensions, meaning only the explicit inclusion of 'zone.js' in the polyfills list will now mark an application as not zoneless. A new test file utils_spec.ts has been introduced to validate this logic. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
The
isZonelessAppfunction incorrectly treats any polyfill entry with a file extension (e.g.,./polyfill-buffer.ts) as an indicator that zone.js is present. This causes apps with custom polyfill files but no zone.js to be incorrectly detected as non-zoneless.Issue Number: #30689
What is the new behavior?
The detection now only checks for the literal
'zone.js'string in the polyfills array, ignoring custom polyfill files with extensions. Added comprehensive unit tests forisZonelessApp.Does this PR introduce a breaking change?