fix(@angular/build): invalidate cached SCSS errors when source files are corrected#32868
Closed
maruthang wants to merge 1 commit intoangular:mainfrom
Closed
fix(@angular/build): invalidate cached SCSS errors when source files are corrected#32868maruthang wants to merge 1 commit intoangular:mainfrom
maruthang wants to merge 1 commit intoangular:mainfrom
Conversation
…are corrected Normalize the file path before looking it up in the dependency map during cache invalidation. Without normalization, the path used for invalidation could differ from the one stored during compilation, causing stale error results to persist after fixing SCSS errors. Fixes angular#32744
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the MemoryLoadResultCache class to ensure that file paths are normalized before being used to invalidate cache entries in the #fileDependencies map. This change improves consistency in how paths are handled during cache invalidation. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
After fixing an SCSS compilation error, the build still shows the old error until a full restart. The cache invalidation fails because the file path is not normalized before lookup in the dependency map.
Issue Number: #32744
What is the new behavior?
Normalize the file path using the existing
normalize()function before looking it up in the dependency map during cache invalidation, ensuring consistent path matching between storage and retrieval.Does this PR introduce a breaking change?