Skip to content

fix(@angular/cli): fix sourceRoot resolution for MCP projects tool#32879

Open
clydin wants to merge 1 commit intoangular:mainfrom
clydin:fix/mcp-projects-source-root
Open

fix(@angular/cli): fix sourceRoot resolution for MCP projects tool#32879
clydin wants to merge 1 commit intoangular:mainfrom
clydin:fix/mcp-projects-source-root

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Mar 27, 2026

Ensure that project.sourceRoot is used directly as it is already relative to the workspace root, preventing duplicated path prefixes for sub-projects.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Mar 27, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the path resolution logic for project source roots to prevent incorrect path prefixing when sourceRoot is already defined. I have no feedback to provide.

@clydin clydin force-pushed the fix/mcp-projects-source-root branch from da4418e to 8be48af Compare March 27, 2026 17:00
Ensure that project.sourceRoot is used directly as it is already relative to the workspace root, preventing duplicated path prefixes for sub-projects.
@clydin clydin force-pushed the fix/mcp-projects-source-root branch from 8be48af to 9ba6527 Compare March 27, 2026 17:25
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 27, 2026
@clydin clydin requested a review from alan-agius4 March 27, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: @angular/cli target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mcp command list_projects incorrectly constructs sourceRoot for multi-project workspaces

1 participant