refactor(@angular/cli): add type safety fallbacks and deduplicate search roots for MCP projects tool#32882
Closed
clydin wants to merge 1 commit intoangular:mainfrom
Closed
refactor(@angular/cli): add type safety fallbacks and deduplicate search roots for MCP projects tool#32882clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces validation for project configuration elements (projectType, prefix, and builder) within the Angular MCP tool. It adds a validationErrors field to the output schema to report malformed or invalid schema elements. Additionally, a new utility function deduplicateSearchRoots was implemented to prevent redundant processing of overlapping search paths. Feedback was provided to refine the projectType validation check to ensure all non-undefined values are correctly validated, maintaining consistency with other property checks.
clydin
force-pushed
the
fix/mcp-projects-validation-and-opt
branch
3 times, most recently
from
76c30b8 to
e00d403
Compare
…rch roots for MCP projects tool Added runtime type checks for `projectType` and `prefix` to prevent unhandled schema exceptions. Implemented `deduplicateSearchRoots` to filter out child directories from overlapping search trees, optimizing filesystem scans. Aggregated validation errors and reported them in the tool output for better visibility.
clydin
force-pushed
the
fix/mcp-projects-validation-and-opt
branch
from
e00d403 to
ebbb01d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added runtime type checks for
projectTypeandprefixto prevent unhandled schema exceptions. ImplementeddeduplicateSearchRootsto filter out child directories from overlapping search trees, optimizing filesystem scans. Aggregated validation errors and reported them in the tool output for better visibility.